Fix installation of core plugins #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the 'plugin.jpi.pinned' file from being deleted.
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Ah good catch! I just noticed some of that code last night but didn't make the connection |
rtyler
pushed a commit
that referenced
this pull request
Sep 26, 2014
Fix installation of core plugins
|
-- Jan
|
|
@bracki it would probably make more sense to check for the exec name rather than the command since that is less brittle. |
bracki
pushed a commit
to Jimdo/puppet-jenkins
that referenced
this pull request
Sep 27, 2014
Fixes broken tests for voxpupuli#188
Merged
tmclaugh
pushed a commit
to hubspotdevops/puppet-jenkins
that referenced
this pull request
Oct 19, 2014
Fixes broken tests for voxpupuli#188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the 'plugin.jpi.pinned' file
from being deleted.
Otherwise Jenkins always starts to manage the plugin by itself.
See #118 #131