Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated virtual_machine.go #699

Closed
wants to merge 2 commits into from
Closed

Conversation

aniketGslab
Copy link
Contributor

Added new function - SearchSnapshot()
SearchSnapshot() is the simple clone of the findSnapshot().
The intention behind cloning this function is to have a functionality for Searching the snapshot which can be used in other packages as well without breaking the current functionality of this library as some of the functions are dependent on findSnapshot()
This function will be useful in other packages.

Added new function - SearchSnapshot()
SearchSnapshot() is the simple clone of the findSnapshot().
The intention behind cloning this function is to have a functionality for Searching the snapshot which can be used in other packages as well  without breaking the current functionality of this library as some of the functions are dependent on findSnapshot()
This function will be useful in other packages.
@vmwclabot
Copy link
Member

@aniketGslab, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@dougm
Copy link
Member

dougm commented Apr 8, 2017

@aniketGslab no need to copy findSnapshot to a new method, why not just export the existing method as FindSnapshot? Dependents can use this exported method too.

@dougm
Copy link
Member

dougm commented May 4, 2017

Closed by #715

@dougm dougm closed this May 4, 2017
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants