-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(csi): allow setting annotation on StorageClass to determine VolumeSnapshotClass #8646
base: main
Are you sure you want to change the base?
feat(csi): allow setting annotation on StorageClass to determine VolumeSnapshotClass #8646
Conversation
…meSnapshotClass Signed-off-by: Carlo Field <[email protected]>
Signed-off-by: Carlo Field <[email protected]>
Signed-off-by: Carlo Field <[email protected]>
For reference, this is the same PR I first opened in the old CSI plugin repo, before realising that repo is outdated. |
Signed-off-by: Carlo Field <[email protected]>
Signed-off-by: Carlo Field <[email protected]>
Signed-off-by: Carlo Field <[email protected]>
2a931b5
to
e8c8283
Compare
Signed-off-by: Carlo Field <[email protected]>
b4678da
to
218f588
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8646 +/- ##
=======================================
Coverage 59.39% 59.39%
=======================================
Files 370 370
Lines 39952 40009 +57
=======================================
+ Hits 23730 23765 +35
- Misses 14731 14750 +19
- Partials 1491 1494 +3 ☔ View full report in Codecov by Sentry. |
@kaovilai is code coverage for error logs something that's needed for approval? |
This PR adds a way to specify the desired VolumeSnapshotClass by annotation in the StorageClass.
An example use case here is Nutanix: The Nutanix CSI driver uses a single provisioner but allows for StorageClasses on either NFS (NutanixFiles) or Volumes (NutanixVolumes). These two StorageClasses require differently configured VolumeSnapshotClasses even though they use the same provisioner.
In Velero, currently, this is only supported by setting an annotation on every PVC you want to back up.
A more scalable approach is to allow setting a default for the StorageClass.
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.