Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test build for all supported client versions. #2987

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

mserajnik
Copy link
Contributor

🍰 Pullrequest

This extends the existing test workflow to build for all currently supported client versions (instead of just 1.12.1) with each compiler (GCC, Clang, MSVC) which will help to prevent compilation errors that affect specific client version builds such as this one.

It also makes it so that all available threads are used instead of the previously hardcoded 2.

Proof

  • None

Issues

  • None

How2Test

  • None

Todo / Checklist

  • None

@ratkosrb
Copy link
Contributor

Won't this overload the CI cause it's too many builds?

@mserajnik
Copy link
Contributor Author

20 jobs can run at the same time. Since there are 21 here now, plus the jobs from the other workflows, some won’t start immediately, but only after others have finished.

So, yes, this will increase the overall time each set of workflow runs takes; imo that tradeoff would be worth it, considering there usually aren’t that many PRs/commits at once that would exhaust the available CI resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants