Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mouse enter and mouse leave events on Advance Marker's Pin #300

Closed
wants to merge 6 commits into from

Conversation

aliasad106
Copy link

This allows to listen mouse over and mouse leave events on the pin of advance marker.

@aliasad106 aliasad106 changed the title Aliasad106 patch 1 Add mouse enter and mouse leave events on Advance Marker's Pin Apr 8, 2024
@usefulthink
Copy link
Collaborator

Thanks for the PR!

Can you explain why the listeners should be added to the Pin instead of the AdvancedMarker component? The way I see it, the Pin is just one of many ways to use the AdvancedMarker and I think we should add support for the DOM events there instead.

@aliasad106
Copy link
Author

@usefulthink because for some reasons adding directly to AdvancedMarker doesn't work.

@usefulthink
Copy link
Collaborator

Ok yeah, that makes sense. I think there was something with the pointer-events css-property that has to be adjusted to use dom-events with the markers. I'll have a look into that.

@isaacpresidium
Copy link

Ok yeah, that makes sense. I think there was something with the pointer-events css-property that has to be adjusted to use dom-events with the markers. I'll have a look into that.

Any update regarding this? what has to be adjusted to make it work?

@aliasad106
Copy link
Author

@isaacpresidium I have created a PR but they never merged it so I am using my own forked one. You can use if you want.

@jogoley
Copy link

jogoley commented Jul 17, 2024

Can this be merged?

@usefulthink
Copy link
Collaborator

Thanks to @mrMetalWood, we finally have a good solution that works reliably for all types of advanced marker: #472

Closing this as outdated.

@usefulthink usefulthink closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants