Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor player.dimension() #4704

Merged
merged 2 commits into from
Nov 1, 2017
Merged

refactor player.dimension() #4704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05ff53c
refactor player.dimension()
kocoten1992 Oct 31, 2017
b44a232
keep variable, so we don't call it twice
kocoten1992 Oct 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/js/player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,17 +656,18 @@ class Player extends Component {
if (value === '') {
// If an empty string is given, reset the dimension to be automatic
this[privDimension] = undefined;
} else {
const parsedVal = parseFloat(value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not keep this variable? Then we won't need to parseFloat twice?

this.updateStyleEl_();
return;
}

if (isNaN(parsedVal)) {
log.error(`Improper value "${value}" supplied for for ${dimension}`);
return;
}
const parsedVal = parseFloat(value);

this[privDimension] = parsedVal;
if (isNaN(parsedVal)) {
log.error(`Improper value "${value}" supplied for for ${dimension}`);
return;
}

this[privDimension] = parsedVal;
this.updateStyleEl_();
}

Expand Down