Prevent dupe events on enabled ClickableComponents (v5) #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it's a huge deal if these are implemented different across the two releases lines. Though, consistency is nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Like #4316 for v6, this prevents multiple click handlers being added if an already enabled component is enabled. In the PR for six,
ClickableComponentwas trackingthis.enabled_but this is incompatible with v5 on aMenuButtonwhich also changes the state ofthis.enabled_.Specific Changes proposed
Removes event handlers in
enable()before adding them.Do we want the same fix implemented in a different way in 5 and 6 though?
Requirements Checklist