test: fix tests #3953
Merged
test: fix tests #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "presets": [ ["es2015", {"loose": true}] ], | |||
| "plugins": ["transform-es3-property-literals", "transform-es3-member-expression-literals", "inline-json"] | |||
| "presets": [ "es3", ["es2015", {"loose": true}] ], | |||
There was a problem hiding this comment.
How much size does this add to the video.js?
There was a problem hiding this comment.
It doesn't. It's equivalent to using the es3 plugins but because of when and how plugins and presets are run, having the preset is more reliable for making sure that things are quoted correctly.
There was a problem hiding this comment.
we should probably switch this in the generator/spellbook
There was a problem hiding this comment.
Yeah, might be good, though, I wouldn't worry too much as long as it continues to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.
Specific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist