Skip to content

Commit

Permalink
fix: menu sizing when using longer caption labels (#5228)
Browse files Browse the repository at this point in the history
Currently, if longer captions labels are used the SubsCaps menu gets all messed up in IE11/Edge. This occurs due to the menu size is not adjusted correctly not taking into consideration the CC icon. This, as a result, causes the captions items not to fit in the menu and because they end up too wide and the menu has overflow: auto style, the horizontal scrollbars show up and cause the menu not to render correctly. Therefore, don't position the caption label absolutely.

Fix #4758.
  • Loading branch information
bcdarius authored and gkatsev committed Jun 11, 2018
1 parent 246f0d4 commit a51b918
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/css/components/_subs-caps.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
}

.video-js .vjs-subs-caps-button + .vjs-menu .vjs-captions-menu-item .vjs-menu-item-text .vjs-icon-placeholder {
position: absolute;
vertical-align: middle;
display: inline-block;
margin-bottom: -0.1em;
}
.video-js .vjs-subs-caps-button + .vjs-menu .vjs-captions-menu-item .vjs-menu-item-text .vjs-icon-placeholder:before {
font-family: VideoJS;
Expand Down

0 comments on commit a51b918

Please sign in to comment.