Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ATMOSPHERE-103] chore: Add loki rule to delect Nova cell down #495

Merged
merged 8 commits into from
Aug 31, 2024

Conversation

okozachenko1203
Copy link
Member

@okozachenko1203 okozachenko1203 commented Jul 20, 2023

fix #490

@mnaser
Copy link
Member

mnaser commented Apr 11, 2024

@okozachenko1203 I think the main issue here is that Loki is not integrated with the AlertManager deployed by the operator, so the alerts will be going to /dev/null.

Can you either make a new PR or update this one to send the alerts to AlertManager (as mentioned in https://grafana.com/docs/loki/latest/alert/#scheduling-and-best-practices)

Once we have that setup, then the alerts will actually "make sense" otherwise now they won't be going anywhere.

@mnaser
Copy link
Member

mnaser commented Apr 12, 2024

Looks like a merge conflict and needs some work to pass CI

@mnaser
Copy link
Member

mnaser commented Apr 21, 2024

recheck

@okozachenko1203
Copy link
Member Author

ok, i found that ruler sidecar is not deployed in singleBInary deployment mode.
grafana/loki#10967

@okozachenko1203
Copy link
Member Author

grafana/loki#13572

@okozachenko1203
Copy link
Member Author

image
now i can get the alert rule in grafana GUI

@mnaser mnaser changed the title chore: Add loki rule to delect Nova cell down [ATMOSPHERE-103] chore: Add loki rule to delect Nova cell down Aug 27, 2024
@mnaser mnaser added the gate label Aug 31, 2024
@atmosphere-ci atmosphere-ci bot merged commit 7c30f26 into main Aug 31, 2024
7 checks passed
@atmosphere-ci atmosphere-ci bot deleted the add-loki-rule branch August 31, 2024 18:52
@mnaser
Copy link
Member

mnaser commented Oct 1, 2024

/cherry-pick stable/2024.1

@mnaser
Copy link
Member

mnaser commented Oct 1, 2024

/cherry-pick stable/2023.2

@mnaser
Copy link
Member

mnaser commented Oct 1, 2024

/cherry-pick stable/2023.1

@mnaser
Copy link
Member

mnaser commented Oct 1, 2024

/cherry-pick stable/zed

@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1938

In response to this:

/cherry-pick stable/2024.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1939

In response to this:

/cherry-pick stable/2023.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1940

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: #495 failed to apply on top of branch "stable/zed":

Applying: Fix lint error
Using index info to reconstruct a base tree...
M	roles/loki/vars/main.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/loki/vars/main.yml
CONFLICT (content): Merge conflict in roles/loki/vars/main.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix lint error
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick stable/zed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: new issue created for failed cherrypick: #1941

In response to this:

/cherry-pick stable/zed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

okozachenko1203 added a commit that referenced this pull request Oct 4, 2024
okozachenko1203 added a commit that referenced this pull request Oct 7, 2024
okozachenko1203 added a commit that referenced this pull request Oct 7, 2024
okozachenko1203 added a commit that referenced this pull request Oct 7, 2024
okozachenko1203 added a commit that referenced this pull request Oct 7, 2024
atmosphere-ci bot pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an alert monitoring logs for list failures
3 participants