Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the vdb verification exactly once semantics for vrep #782

Merged
merged 1 commit into from
May 1, 2024
Merged

Give the vdb verification exactly once semantics for vrep #782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/controllers/vrep/vdbverify_reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ func MakeVdbVerifyReconciler(r *VerticaReplicatorReconciler, vrep *v1beta1.Verti
// Reconcile will verify the verticaDBs in the vrep CR source and target exist and
// both vertica versions support the replication feature
func (r *VdbVerifyReconciler) Reconcile(ctx context.Context, _ *ctrl.Request) (ctrl.Result, error) {
// no-op if the check has already been done once and was successful
isSet := r.Vrep.IsStatusConditionTrue(v1beta1.ReplicationReady)
if isSet {
// no-op if ReplicationReady is present (either true or false)
isPresent := r.Vrep.IsStatusConditionPresent(v1beta1.ReplicationReady)
if isPresent {
return ctrl.Result{}, nil
}

Expand Down
Loading