Skip to content

Commit

Permalink
VCluster API refresh: better handling during remove node interruptions (
Browse files Browse the repository at this point in the history
#655)

Updates to the vcluster API incorporate the following fixes:
- Removing a node from a k-safety 0 database could cause the cluster to
lose quorum.
- The API has been improved to handle interruptions during node removal.

Without these fixes, it is possible that the operator could lose cluster
quorum during node removal and then have difficulty starting the
database.

These fixes allow us to move some tests out of quarantine that were
moved in #639.
  • Loading branch information
spilchen authored Jan 8, 2024
1 parent a97d95f commit 435a7a7
Show file tree
Hide file tree
Showing 89 changed files with 9 additions and 3 deletions.
5 changes: 5 additions & 0 deletions changes/unreleased/Fixed-20240105-082914.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
kind: Fixed
body: Better handling when remove node is interrupted
time: 2024-01-05T08:29:14.357532789-04:00
custom:
Issue: "655"
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ require (
github.com/onsi/gomega v1.24.2
github.com/pkg/errors v0.9.1
github.com/prometheus/client_golang v1.14.0
github.com/vertica/vcluster v1.0.1-0.20240104123029-09a503fb0ccc
github.com/vertica/vcluster v1.0.1-0.20240104202842-a05178dd119a
github.com/vertica/vertica-sql-go v1.1.1
go.uber.org/zap v1.25.0
gopkg.in/natefinch/lumberjack.v2 v2.0.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@ github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO
github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
github.com/stretchr/testify v1.8.2 h1:+h33VjcLVPDHtOdpUCuF+7gSuG3yGIftsP1YvFihtJ8=
github.com/tonglil/buflogr v1.0.1 h1:WXFZLKxLfqcVSmckwiMCF8jJwjIgmStJmg63YKRF1p0=
github.com/vertica/vcluster v1.0.1-0.20240104123029-09a503fb0ccc h1:gcp1uM4y1JkXncmKcG0xA/AOyjxi5cGHA3glQ4QMwio=
github.com/vertica/vcluster v1.0.1-0.20240104123029-09a503fb0ccc/go.mod h1:mr87BZeipS9HMaL1vKST7lbJ1+SytCbruTF+8tsdK78=
github.com/vertica/vcluster v1.0.1-0.20240104202842-a05178dd119a h1:+KNSKOx0PGaIfIzlBJ31melPGIXQUZJTL8Oab9Elri0=
github.com/vertica/vcluster v1.0.1-0.20240104202842-a05178dd119a/go.mod h1:mr87BZeipS9HMaL1vKST7lbJ1+SytCbruTF+8tsdK78=
github.com/vertica/vertica-sql-go v1.1.1 h1:sZYijzBbvdAbJcl4cYlKjR+Eh/X1hGKzukWuhh8PjvI=
github.com/vertica/vertica-sql-go v1.1.1/go.mod h1:fGr44VWdEvL+f+Qt5LkKLOT7GoxaWdoUCnPBU9h6t04=
github.com/yuin/goldmark v1.1.25/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
Expand Down
1 change: 1 addition & 0 deletions pkg/vadmin/remove_node_vc.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ func (v *VClusterOps) genRemoveNodeOptions(s *removenode.Parms, certs *HTTPSCert
opts.RawHosts = []string{s.InitiatorIP}
opts.Ipv6 = vstruct.MakeNullableBool(net.IsIPv6(s.InitiatorIP))
opts.DataPrefix = &v.VDB.Spec.Local.DataPath
*opts.CatalogPrefix = v.VDB.Spec.Local.GetCatalogPath()
*opts.HonorUserInput = true

if v.VDB.Spec.Communal.Path != "" {
Expand Down

0 comments on commit 435a7a7

Please sign in to comment.