Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (core): send buffered text in smooth stream when stream parts change #5531

Merged
merged 7 commits into from
Apr 3, 2025
Merged

fix (core): send buffered text in smooth stream when stream parts change #5531

merged 7 commits into from
Apr 3, 2025
+167 −6

Conversation

lgrammel
Copy link
Collaborator

@lgrammel lgrammel commented Apr 3, 2025

Continues #5475

carlbrugger and others added 6 commits March 31, 2025 20:14
@carlbrugger
fix regex
774594f 
The word-based regex pattern (/\s*\S+\s+/m) requires trailing whitespace after each word. The last text-delta won't have a trailing space causing the last word in the last text-delta to not be returned until after any tool calls the model may make.
@carlbrugger
flush buffer when chunk type changes
4589daa
@carlbrugger
add back semicolons
849f02c
@carlbrugger
revert while loop
ad51e53
@lgrammel
revert
7c9ba90
@lgrammel
fix (core): send buffered text in smooth stream when stream parts change
24a7122
samdenty
samdenty approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@samdenty samdenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lgrammel lgrammel merged commit c45d100 into main Apr 3, 2025
7 checks passed
@lgrammel lgrammel deleted the lg/5475 branch April 3, 2025 12:03
lgrammel added a commit that referenced this pull request Apr 3, 2025
@lgrammel @carlbrugger
fix (core): send buffered text in smooth stream when stream parts cha…
8026705 
…nge (#5531)

Co-authored-by: Carl Brugger <[email protected]>
samdenty added a commit that referenced this pull request Apr 3, 2025
@samdenty
Merge remote-tracking branch 'origin/main' into feat/smooth-stream-cjk
08fd40c 
* origin/main:
  docs: Use new `create-nuxt` tool when starting Nuxt projects (#5175)
  chore (ui/react,vue): update more tests to unified test server (#5509)
  Version Packages (#5532)
  fix (core): send buffered text in smooth stream when stream parts change (#5531)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdenty samdenty samdenty approved these changes

@nicoalbanese nicoalbanese nicoalbanese approved these changes

Assignees

@lgrammel lgrammel

@samdenty samdenty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgrammel @samdenty @nicoalbanese @carlbrugger