Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (provider/openai): respect web search as tool choice #5442

Merged
merged 3 commits into from
Mar 30, 2025
Merged

fix (provider/openai): respect web search as tool choice #5442

merged 3 commits into from
Mar 30, 2025
+122 −1

Conversation

iteratetograceness
Copy link
Collaborator

@iteratetograceness iteratetograceness commented Mar 29, 2025 •
edited
Loading

todo update docs

resolves #5380

lgrammel
lgrammel approved these changes Mar 29, 2025
View reviewed changes
Copy link
Collaborator

@lgrammel lgrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, does this work e2e?

needs a changeset before merging (realize this is still a draft)

@lgrammel lgrammel changed the title fix: respect web search as tool choice fix (provider/openai): respect web search as tool choice Mar 29, 2025
@iteratetograceness
Copy link
Collaborator Author

@lgrammel yes, tested e2e using the new example I added!

@iteratetograceness iteratetograceness marked this pull request as ready for review March 30, 2025 21:54
@iteratetograceness iteratetograceness merged commit 52ed95f into vercel:main Mar 30, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgrammel lgrammel lgrammel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forcing OpenAI's Web Search tool doesn't work with toolChoice
2 participants
@iteratetograceness @lgrammel