Authentication: Fix CME immediate update_connection_password to use username #3330
+426
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lior Sventitzky <[email protected]>
Signed-off-by: Lior Sventitzky <[email protected]>
Signed-off-by: Lior Sventitzky <[email protected]>
Signed-off-by: Lior Sventitzky <[email protected]>
Signed-off-by: Lior Sventitzky <[email protected]>
Signed-off-by: Lior Sventitzky <[email protected]>
Signed-off-by: Lior Sventitzky <[email protected]>
liorsve
force-pushed
the
add-username-auth
branch
from
225ff28 to
d19562d
Compare
liorsve
added
Rust core
Signed-off-by: Lior Sventitzky <[email protected]>
| } | ||
| } | ||
| ClientWrapper::Standalone(_) => { | ||
| //TODO: get username and add it as arg in standalone |
There was a problem hiding this comment.
Do you plan to implement this in the current PR?
If no, create a task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue: #3289
This PR fixes the update connection password to add the username as arg in
update_connection_password(immediateAuth = True)(i.e. send "AUTH [username] [password]") in case username was configured in ServerCredentials during client creation.Currently, only "AUTH [password]" is sent.
NOTE - currently, the Node tests (also those that were added when update_connection_password was implemented, that are also supposed to check the CMD case) are effectively running on CME only. This needs to change in a follow-up PR that would fix update_connection_password for CMD.
Checklist
Before submitting the PR make sure the following are checked: