Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: randomize cluster ports for Example tests #3225

Merged
merged 19 commits into from
Mar 4, 2025
Merged

Go: randomize cluster ports for Example tests #3225

merged 19 commits into from
Mar 4, 2025

Conversation

jbrinkman
Copy link
Collaborator

Issue link

This Pull Request is linked to issue (#3224)

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@jbrinkman jbrinkman requested a review from a team as a code owner February 21, 2025 23:09
@jbrinkman jbrinkman force-pushed the go/jbrinkman-randomize-cluster-ports branch from 0b3b79f to 397bffa Compare February 21, 2025 23:19
Yury-Fridlyand
Yury-Fridlyand reviewed Feb 21, 2025
View reviewed changes
@Yury-Fridlyand Yury-Fridlyand added go golang wrapper testing Everything about testing labels Feb 21, 2025
@yipin-chen
Copy link
Collaborator

Your CI is red. Please don't forget to update CHANGELOG.

@jbrinkman jbrinkman force-pushed the go/jbrinkman-randomize-cluster-ports branch from ebb16b5 to be68ac2 Compare February 27, 2025 22:39
Yury-Fridlyand
Yury-Fridlyand reviewed Feb 28, 2025
View reviewed changes
@jbrinkman jbrinkman force-pushed the go/jbrinkman-randomize-cluster-ports branch from fce29ba to 98a3d00 Compare March 3, 2025 20:18
@jbrinkman jbrinkman changed the title Go/jbrinkman randomize cluster ports Go: randomize cluster ports for Example tests Mar 3, 2025
Yury-Fridlyand
Yury-Fridlyand reviewed Mar 3, 2025
View reviewed changes
@jbrinkman jbrinkman force-pushed the go/jbrinkman-randomize-cluster-ports branch from 41c5f3f to d3d76c5 Compare March 4, 2025 12:34
Yury-Fridlyand
Yury-Fridlyand approved these changes Mar 4, 2025
View reviewed changes
jamesx-improving
jamesx-improving approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@jamesx-improving jamesx-improving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please remove test.txt as Yury mentioned.
  2. Not entirely sure, but do we need to remove this statement from the Examples section of go/DEVELOPER.md?
To run all examples, ensure ports 6379, 7001, 7002, 7003, 7004, 7005, 7006 are not being used, and then run the following:

Other than above 2 items, LGTM.

jbrinkman added 12 commits March 4, 2025 16:14
@jbrinkman
temp save
4b4efc3 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
add custom flags for example tests
140cabc 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
update example utils to use randomized cluster nodes
ba797e1 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
cleanup temp work in makefile
98025a6 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
fix formatting
2bc52da 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
interim save for randomizing ports pr
e3cbb53 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
randomize the standalone node address for example-test
28a3509 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
remove debugging console logs
4dc7c92 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
remove replica count flag
f9fc153 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
fix formatting
dbc42c5 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
disable running LCS examples since they can't run in our matrixed env…
0c82a89 
…ironments

Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
don't run example tests against Redis 6.2 servers
db5a04d 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman jbrinkman force-pushed the go/jbrinkman-randomize-cluster-ports branch from bacc614 to 0030493 Compare March 4, 2025 21:14
jbrinkman and others added 7 commits March 4, 2025 16:18
@jbrinkman @Yury-Fridlyand
Update go/api/string_commands_test.go
895b7ba 
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Joseph Brinkman <[email protected]>
@jbrinkman
Route flush commands to all primaries
3d5cf6c 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
stop cluster servers even after an error
ff7bbc2 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman @Yury-Fridlyand
Update .github/workflows/go.yml
9cb1923 
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Joseph Brinkman <[email protected]>
@jbrinkman
remove example tests in test-go-containers job
e7e3db5 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman @Yury-Fridlyand
Update go/api/string_commands_test.go
e94d641 
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Joseph Brinkman <[email protected]>
@jbrinkman
remove extraneous file and update developer documentation
08fa089 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman jbrinkman force-pushed the go/jbrinkman-randomize-cluster-ports branch from 0030493 to 08fa089 Compare March 4, 2025 21:18
@jbrinkman jbrinkman merged commit cd86f5f into main Mar 4, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@jamesx-improving jamesx-improving jamesx-improving approved these changes

Assignees
No one assigned
Labels
go golang wrapper testing Everything about testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrinkman @yipin-chen @Yury-Fridlyand @jamesx-improving