Wrap Comments #1003
Closed
Wrap Comments #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git can keep track of this for us
|
Looks like we'll have to manually fix some code examples, lists, and tables with this change, so maybe I'll leave this for another time... |
|
I am against enabling this rustfmt rule since it uglifies a lot of comments imo. i tried it and it severely did not satisfy me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at #979 I noticed that Robin (kinda) wrapped my module comments. I wondered
if we had any
RustFmtconfig around that, and it turns out that while we did(
comment_width = 80) we were not actual using it since we hadwrap_comments = false.According to the
comment_widthdocs we need to set it totruein order for it to have an effect.