Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust specific build info to metadata #680
Add Rust specific build info to metadata #680
Changes from 21 commits
8fd0b84
92ad530
42e22c4
beac37e
f6c3fa2
ad19ec9
a12564c
b7a3d18
6a2a1b3
8d5f92d
5a2ad6a
415ec3d
7ec78dd
5c65ff9
46ea782
276a7a4
8a6630c
83aed6d
bae9094
00e8213
a75b726
6eea64c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why we convert to loosely typed json
Map
here? Is that for alt. compilers e.g.solang
to provide arbitrary data here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, other compilers may want to include other info here. It's also useful for us if we decide that we need to add/remove info later on