Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve PolkaVM target spec from linker #1939

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Retrieve PolkaVM target spec from linker #1939

merged 3 commits into from
Feb 26, 2025

Conversation

davidsemakula
Copy link
Contributor

@davidsemakula davidsemakula commented Feb 14, 2025 •
edited
Loading

Summary

Closes N/A

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on the specific version of ink or pallet-contracts?

Retrieve PolkaVM target spec from linker

Description

Removes PolkaVM target spec file from contract-build and instead reads it from polkavm-linker.

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@davidsemakula davidsemakula marked this pull request as ready for review February 14, 2025 08:14
@cmichi cmichi merged commit 09c46b1 into master Feb 26, 2025
9 checks passed
@cmichi cmichi deleted the semakula/polkavm-target-spec branch February 26, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmichi cmichi cmichi approved these changes

@ascjones ascjones Awaiting requested review from ascjones ascjones is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidsemakula @cmichi