Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contract build with lint option to CI #1496

Merged
merged 11 commits into from
Feb 14, 2024
Merged

Add contract build with lint option to CI #1496

merged 11 commits into from
Feb 14, 2024

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Feb 7, 2024 •
edited
Loading

Summary

Closes #_

  • y/n | Does it introduce breaking changes?
  • y/n | Is it dependent on the specific version of ink or pallet-contracts?

Add contract build with lint option to CI

Description

Add contract build with lint option to CI, where nightly toolchain is used

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

jubnzv
jubnzv reviewed Feb 7, 2024
View reviewed changes
@smiasojed smiasojed changed the title Add workaround for ismd issue Add workaround for simd issue Feb 7, 2024
@smiasojed smiasojed marked this pull request as ready for review February 7, 2024 17:23
@smiasojed smiasojed requested review from cmichi, ascjones, SkymanOne and a team as code owners February 7, 2024 17:23
@smiasojed smiasojed changed the title Add workaround for simd issue Add contract build with lint option to CI Feb 12, 2024
@smiasojed smiasojed requested a review from jubnzv February 12, 2024 12:21
@smiasojed smiasojed merged commit c6b246c into master Feb 14, 2024
11 checks passed
@smiasojed smiasojed deleted the sm/ismd-issue branch February 14, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubnzv jubnzv jubnzv approved these changes

@rcny rcny rcny approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@ascjones ascjones Awaiting requested review from ascjones ascjones is a code owner

@SkymanOne SkymanOne Awaiting requested review from SkymanOne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smiasojed @rcny @jubnzv