Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generics for info and storage commands #1465

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Add generics for info and storage commands #1465

merged 6 commits into from
Feb 2, 2024

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Jan 22, 2024 •
edited
Loading

Summary

Related #1168

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on the specific version of ink or pallet-contracts?

Add generics for the 'info' and 'storage' commands

Description

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@smiasojed smiasojed marked this pull request as ready for review January 22, 2024 15:22
ascjones
ascjones approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SkymanOne
SkymanOne approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@SkymanOne SkymanOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add changelog entry before you merge

@smiasojed
Copy link
Collaborator Author

LGTM. Please add changelog entry before you merge

I am not sure if I should add it into changelog, it does not affect an user, it is just internal change. WDYT?

@SkymanOne
Copy link
Contributor

LGTM. Please add changelog entry before you merge

I am not sure if I should add it into changelog, it does not affect an user, it is just internal change. WDYT?

Generally speaking, unless the change is <10 loc, it's worth adding an entry just for internal reporting reasons so we know what and when it was changed.

cmichi
cmichi approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with not having a changelog entry, as the change doesn't change behavior of cargo-contract for users.

@smiasojed smiasojed merged commit 195329d into master Feb 2, 2024
11 checks passed
@smiasojed smiasojed deleted the sm/gen-part1 branch February 2, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@cmichi cmichi cmichi approved these changes

@SkymanOne SkymanOne SkymanOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smiasojed @SkymanOne @ascjones @cmichi