-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generics to extrinsics crate #1463
Conversation
07616bf
to
4bc30da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Sebastian. Looks good!
assert!(parse_code_hash( | ||
"d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d" | ||
) | ||
.is_ok()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a test for the failure case .is_err()
.
Co-authored-by: Michael Müller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a bit more in the PR description to explain the change and how it is an intermediate step towards #1463.
Summary
Related #1168
ink
orpallet-contracts
?Add generics to extrinisics crate
Description
The PR removes PolkadotConfig and DefaultEnvironment from the extrinsics crate and makes use of generics for Hash, Account and Balance.
Checklist before requesting a review
CHANGELOG.md