Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generics to extrinsics crate #1463

Merged
merged 23 commits into from
Feb 14, 2024
Merged

Add generics to extrinsics crate #1463

merged 23 commits into from
Feb 14, 2024

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Jan 19, 2024

Summary

Related #1168

  • y/n | Does it introduce breaking changes?
  • y/n | Is it dependent on the specific version of ink or pallet-contracts?

Add generics to extrinisics crate

Description

The PR removes PolkadotConfig and DefaultEnvironment from the extrinsics crate and makes use of generics for Hash, Account and Balance.

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@smiasojed smiasojed marked this pull request as ready for review February 5, 2024 16:53
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sebastian. Looks good!

assert!(parse_code_hash(
"d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d"
)
.is_ok())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a test for the failure case .is_err().

Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a bit more in the PR description to explain the change and how it is an intermediate step towards #1463.

@smiasojed smiasojed changed the title Add generics Add generics to extrinsics crate Feb 6, 2024
@smiasojed smiasojed merged commit fc0f059 into master Feb 14, 2024
11 checks passed
@smiasojed smiasojed deleted the sm/generics branch February 14, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants