-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat!: add more integers and unsigned integers #2094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6860a88
to
bb0cbe7
Compare
@somebadcode Can you run |
57dcf48
to
c11b9b2
Compare
@dearchap I've addressed the things you pointed out and I've added basic tests for all the new flag types. |
This change is breaking again, right? I'm wondering about how this will be released. Will we see v4 soon? |
Yes, it's breaking since it changes I was a bit too slow to make it to the v3 release. I initially hoped that they'd held back the release of v3 because of these mistakes since the use of generics makes is really easy to cover all the different integers and floats. So maybe correcting these short-comings will cause a v4 in a not too distant future? |
Yes breaking change. Can't help it. |
c11b9b2
to
f0e708d
Compare
* Reintroduced all variants of integers and unsigned integers. Fixes: urfave#2050 Signed-off-by: Tobias Dahlberg <[email protected]>
f0e708d
to
d48cfd9
Compare
Fixes: #2050
What type of PR is this?
What this PR does / why we need it:
Only having flags for
int64
anduint64
when generics can be used to make it support all of them is very limiting and forces the users of the package to create wrappers if the variable that they want to configure using a flag is not part of their project or adds unnecessary bloat by having less appropriate integer types and conversions of those integers.Which issue(s) this PR fixes:
Fixes #2050
Release Notes
(REQUIRED)