-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix:(issue_2056) Add cmd.XXXArgs() functions for retrieving args #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dearchap
wants to merge
14
commits into
urfave:main
Choose a base branch
from
dearchap:issue_2056
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juneezee
reviewed
Apr 14, 2025
meatballhat
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fully admit that I mostly skimmed this! I'd love to know the answer to @Juneezee's question, too, but I don't have any blocking feedback.
Other notes:
- I'm reminded that I'd like to make sure argument and flag types from external packages are possible.
- The use of private members in the public
ArgumentBase
declarations still looks funny to me 🤔 e.g. thetimestampValue
inArgumentsBase[time.Time, TimestampConfig, timestampValue]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Add functions to allow Args access. Two classes of functions are available on the command
one for single value arguments and one for multi value/slice
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #2056
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
go test -run=Test*Args
Release Notes
(REQUIRED)