Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target_vault_name reference a resource not a variable #2

Merged
merged 8 commits into from
Nov 13, 2020
Merged

target_vault_name reference a resource not a variable #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
22600f5
Add depends on to fix the occasional race condition
Nov 12, 2020
1a659b2
Add changelog
Nov 12, 2020
38587f7
Use resource and not variable for 'depends_on'
Nov 12, 2020
66f3095
Add comment for depends_on
Nov 12, 2020
0815af4
Fix target_vault_name should be referencing a resource and not a vari…
Nov 12, 2020
6dcde75
Remove unreleased part for Changelog
Nov 12, 2020
b1df6c6
Fix expression for target_vault_name
Nov 12, 2020
d5d9fa4
New expression for target_vault_name
Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Change Log

All notable changes to this project will be documented in this file.

<a name="1.0.0"></a>
## 1.0.0 - 2020-11-09

- Complete AWS Backup module ([#1](https://github.com/umotif-public/terraform-aws-backup/issues/1))
- Initial commit


[Unreleased]: https://github.com/umotif-public/terraform-aws-backup/compare/1.0.0...HEAD
4 changes: 3 additions & 1 deletion examples/external-vault/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,6 @@ module "backup" {
tags = {
Environment = "test"
}
}

depends_on = [aws_backup_vault.external_vault]
}
1 change: 0 additions & 1 deletion examples/one-db/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ module "backup" {
rules = [
{
name = "test-backup-rule"
target_vault_name = "test-rds-aurora"
schedule = "cron(0 12 * * ? *)"
start_window = "65"
completion_window = "180"
Expand Down
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ resource "aws_backup_plan" "main" {
for_each = var.rules
content {
rule_name = lookup(rule.value, "name")
target_vault_name = lookup(rule.value, "target_vault_name", null) == null ? var.vault_name : lookup(rule.value, "target_vault_name", "Default")
target_vault_name = var.vault_name != null ? aws_backup_vault.main[0].name : lookup(rule.value, "target_vault_name", "Default")
schedule = lookup(rule.value, "schedule", null)
start_window = lookup(rule.value, "start_window", null)
completion_window = lookup(rule.value, "completion_window", null)
Expand Down