Need spaces around bash subs

ukhsa-collaboration · Feb 3, 2025 · 23adfd3 · 23adfd3
1 parent 3dfcfe2
commit 23adfd3
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/.github/workflows/distribute_package.yml b/.github/workflows/distribute_package.yml
@@ -71,8 +71,11 @@ jobs:
         if: ${{ startsWith(github.ref, 'refs/tags') }}
         run: |
           # Set tag from GitHub: using git describe for tags inside the run script
-          # seems not working
-          echo "VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
+          # seems not working - I think this because you need _annotated_ tags
+          # for git describe i.e. you need to tag the release as so:
+          # 'git tag vX.Y.Z -a -m "YOUR MESSAGE HERE"'
+          # echo "VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
+          echo "VERSION=${ git describe }" >> $GITHUB_ENV
 
       - name: Install dependencies
         run: |
@@ -134,7 +137,7 @@ jobs:
           # for git describe i.e. you need to tag the release as so:
           # 'git tag vX.Y.Z -a -m "YOUR MESSAGE HERE"'
           # echo "VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
-          echo "VERSION=${git describe}" >> $GITHUB_ENV
+          echo "VERSION=${ git describe }" >> $GITHUB_ENV
 
       # setuptools_scm workaround for https://github.com/pypa/setuptools_scm/issues/455
       - name: Disable local version identifier on develop CI