-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: save token and partner data in supabase on permit generation #285
feat: save token and partner data in supabase on permit generation #285
Conversation
Caution No labels are set. |
Not sure on how to QA this. |
@gentlementlegen caution should be reserved for application errors. This should be a warning because its changeable based on the inputs (change the labels) |
Pls:
|
…-rewards into fix-supabase-permits
…-conversation-rewards into fix-supabase-permits
…-rewards into fix-supabase-permits
Sorry, took some time but here is the QA! @rndquu @gentlementlegen supabase-qa.mp4 |
@zugdev I'll have a look at it tomorrow. Does it retroactively need to fix previous permits, since the previous ones did not save this info? |
I will write a backfill script, apparently it makes more sense to have it here in the backend. |
I made a backfill script that looks into the permit's origin URL (e.g #284) and then matches all ![]() ![]() There are still some permits that don't match because they were deleted or voided. An example is permit 322, generated at ubiquity-os-marketplace/command-start-stop#2 which you have confirmed in a comment was invalidated. To run you can simply do As of now, what allows us to fetch ![]() However the table ![]() In my fork of the DB I will create the same rule, however someone with better context can decide if it's appropriate in production. |
…-rewards into fix-supabase-permits
added better github handling (retrials, wait on rate limit, skip on 404...) action QA: https://github.com/zugdev/conversation-rewards/actions/runs/13557258018/job/37893854455 |
this jest fail is from an rpc timeout. @gentlementlegen I'd be happy if you could prioritize wrapping this so I can follow up with ubiquity/pay.ubq.fi#383 (comment) :) dont worry if you cant |
@zugdev usually when RPC times out I just relaunch tests until it picks an RPC that is fast enough. Let me restart it. |
@gentlementlegen done. I don't have permission to set secrets in this repo, so I'd appreciate if you could set |
…-rewards into fix-supabase-permits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just set the private key in the environment.
@zugdev, you have used |
Nice, @gentlementlegen can we merge and run the action? |
@zugdev please resolve conflicts first |
…-conversation-rewards into fix-supabase-permits
…-rewards into fix-supabase-permits
Resolves #284