Add Char/Byte specialization to kernel typeclasses #4547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason why this is usually not done is that it increases the size of all the traits but boxing is cheaper for Byte and Char because they are generally cached: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add specialization for two more primitive types for Typeclasses in the kernel.
Bytes and, in a lesser extend, Chars, are fundamental types in many domains and I feel this is worth an addition. This does have an effect in JAR size though.
Size tested using scala 2.13 (
publishLocal).5c5fe56)82a342e)Looking forward your feedback !