Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand CI #291

Merged
merged 12 commits into from
Dec 6, 2020
Merged

Expand CI #291

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c05c794
Test against CPython 3.8 and 3.9
altendky Dec 3, 2020
8b4d736
Test against PyPy 2 and 3
altendky Dec 3, 2020
6df19a5
Add macOS to CI
altendky Dec 4, 2020
917b0bc
Merge branch 'master' into test_against_macos
altendky Dec 5, 2020
3080b47
Merge branch 'master' into test_against_pypy
altendky Dec 5, 2020
0675764
Merge branch 'master' into add_cp38_cp39
altendky Dec 5, 2020
a22ce21
Merge branch 'test_against_macos' into expand_ci
altendky Dec 5, 2020
48dfb6b
Merge branch 'test_against_pypy' into expand_ci
altendky Dec 5, 2020
2aabcd4
Merge branch 'add_cp38_cp39' into expand_ci
altendky Dec 5, 2020
a6a5044
Add 291.misc.rst
altendky Dec 5, 2020
5f4b02a
Switch to CPython 3.8 for checks
altendky Dec 6, 2020
a00127f
Comment on use of second-most-recent minor release for checks
altendky Dec 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,16 @@ on:

jobs:
test:
name: ${{ matrix.task.name}} - ${{ matrix.python.name }}
runs-on: ubuntu-latest
name: ${{ matrix.task.name}} - ${{ matrix.os.name }} ${{ matrix.python.name }}
runs-on: ${{ matrix.os.runs-on }}
strategy:
fail-fast: false
matrix:
os:
- name: Linux
runs-on: ubuntu-latest
- name: macOS
runs-on: macos-latest
python:
- name: CPython 2.7
tox: py27
Expand All @@ -26,6 +31,18 @@ jobs:
- name: CPython 3.7
tox: py37
action: 3.7
- name: CPython 3.8
tox: py38
action: 3.8
- name: CPython 3.9
tox: py39
action: 3.9
- name: PyPy 2
tox: pypy2
action: pypy2
- name: PyPy 3
tox: pypy3
action: pypy3
task:
- name: Test
tox: tests
Expand All @@ -48,7 +65,7 @@ jobs:

- name: Codecov
run: |
codecov -n "GitHub Actions - ${{ matrix.task.name}} - ${{ matrix.python.name }}"
codecov -n "GitHub Actions - ${{ matrix.task.name}} - ${{ matrix.os.name }} ${{ matrix.python.name }}"

check:
name: ${{ matrix.task.name}} - ${{ matrix.python.name }}
Expand All @@ -57,9 +74,9 @@ jobs:
fail-fast: false
matrix:
python:
- name: CPython 3.6
tox: py36
action: 3.6
- name: CPython 3.8
tox: py38
action: 3.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for this to move to 3.8 instead of 3.9? It seems reasonable to bump it up, since CPython 3.6 is nearing the end of its supported life. All else equal, I guess 3.9 would be a better new target since it will be supported for longer ... but maybe there are other concerns?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured that a little extra stability isn't a bad thing on the checks. They are there to work, not exercise against latest. And sure, 3.9 isn't all that new, but it doesn't have a patch release yet and my brain works a bit better without nuance. Just use the second-most-recent minor and done. When adding 3.10 to the test matrix we could bump this to 3.9. (Though sure, I don't think I actually apply this explicitly anywhere else. Maybe next time I will. :])

I guess I could afford a brief comment as to the intent.

altendky marked this conversation as resolved.
Show resolved Hide resolved
task:
- name: Flake8
tox: flake8
Expand Down
Empty file added src/towncrier/newsfragments/291.misc.rst
View file
Open in desktop
Empty file.