Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and version #99

Closed

Conversation

mc-nv
Copy link
Contributor

@mc-nv mc-nv commented Jan 16, 2025

@@ -38,6 +38,7 @@ matrix below:

| Triton CLI Version | TRT-LLM Version | Triton Container Tag |
|:------------------:|:---------------:|:--------------------:|
| 0.1.4 | v0.17.0 | 25.01 |
Copy link
Collaborator

@rmccorm4 rmccorm4 Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Misha - but we shouldn't bump these versions if we haven't updated the TRT-LLM templates and haven't tested/fixed any issues that come up with it.

We can bump the version after we prioritize upgrading and validating, but it likely won't be this week.

I appreciate your diligence here 🫡

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issue, I raise this PR especially to understand nature of this record.
I will followup on it tomorrow by addressing the comments.

Copy link
Collaborator

@rmccorm4 rmccorm4 Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I'd prefer we close this triton_cli PR and come back to it - it generally has a delay in being updated between releases and isn't currently tied to the release branch / code freeze. If we upgrade the versions, things will likely break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants