test: Add Python backend response parameters test #7964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
20 tasks
kthui
force-pushed
the
jacky-py-res-param
branch
from
e166889 to
adb5931
Compare
rmccorm4
reviewed
Jan 24, 2025
| fi | ||
|
|
||
| set +e | ||
| python3 -m pytest --junitxml=response_parameters_test.report.xml response_parameters_test.py > $TEST_LOG 2>&1 |
There was a problem hiding this comment.
Thanks for using pytest to generate the report 🚀
* Testing to check parameters set in response object * Complete basic response parameter test case * Complete the response parameters test and add decoupled test * Add leak detector to tests * Pre-commit fix * Add non-str key type to test case
kthui
force-pushed
the
jacky-py-res-param
branch
from
adb5931 to
9370d22
Compare
krishung5
approved these changes
Jan 24, 2025
rmccorm4
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Add tests for Python backend response parameters.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/python_backend#394
Where should the reviewer start?
Start with
test_setting_three_element_response_parameterstest case first to get a sense on the feature, and then move on to other test cases, and finish withtest_setting_response_parameters_decoupledtest case.Test plan:
N/A
Caveats:
N/A
Background
N/A
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
N/A