Bump to v2.0.0 with cleanup #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking changes: - The `static-onig` feature was removed, static linking is now the default - Font styles and color constants now use associated consts because of bitflags upgrade - SyntaxDefinition::load_from_str now has an extra parameter As well as bumping the version this commit does some cleaning up for the breaking changes.
est31
reviewed
Jan 2, 2018
| @@ -13,7 +13,11 @@ use std::fs::File; | |||
| use std::ops::DerefMut; | |||
| use std::mem; | |||
| use std::rc::Rc; | |||
|
|
|||
| // TODO this is unused in nightly but used in stable, remove eventually | |||
There was a problem hiding this comment.
More precisely, in 1.23 (current beta, reaching stable soon, on Jan 4th) it is unused, and in 1.22.1 (current stable) it is used.
|
I published a new release to crates.io and added some release notes to a Github Release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes:
static-onigfeature was removed, static linking is now the defaultOther notable changes:
embedsyntax Update code to work with new embed syntax #124As well as bumping the version this commit does some cleaning up for the breaking changes.
Thanks to @Keats @keith-hall and @est31 for your significant contributions to this release!