fix: correctly recognize multiple inheritance for @class
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: (Before / After) 
|
|
I see a lot of style changes in src/tree_sitter/parser.h, this is probably due to the different tree-sitter CLI version used. I used 0.20.8; please let me know if this is causing any problem/conflicts. |
|
@amaanq kindly bumping this up. |
Problem: Inheritance from multiple parent types are not correctly recognized, only the first parent class was parsed as identifier. Solution: Use commaSep to recognize multiple parent types.
amaanq
force-pushed
the
class-inheritance
branch
from
0aacc64 to
ef5a0bb
Compare
|
Thank you for the PR! And I'm sorry about being MIA For future tree-sitter parser related PRs, make sure your cli is built from master, there's slight changes in the generation output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Inheritance from multiple parent types are not correctly
recognized, only the first parent class was parsed as identifier.
Solution: Use commaSep to recognize multiple parent types.