Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbo #67

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Turbo #67

merged 6 commits into from
Nov 13, 2024

Conversation

kvz
Copy link
Member

@kvz kvz commented Nov 13, 2024

No description provided.

@Murderlon
Copy link
Member

I wonder if turbo is actually needed as tsc already has caching so re-running it when only one package changed is still fast. I recently removed it from tus-node-server. @remcohaszing may have some thoughts on this as well.

@kvz
Copy link
Member Author

kvz commented Nov 13, 2024

It's not just about speeding up a lerna powered tsc run tho is it?

A full test run just went from 20+ seconds to 0.2 for instance:

CleanShot 2024-11-13 at 11 43 07@2x

@Murderlon
Copy link
Member

It's not cached in CI so it will always run the full suite there. Locally if you're iterating that's why the test:watch command is there?

@kvz
Copy link
Member Author

kvz commented Nov 13, 2024

Added caching for CI 👌

@kvz
Copy link
Member Author

kvz commented Nov 13, 2024

BEFORE (40s):

CleanShot 2024-11-13 at 12 00 34@2x

AFTER (1s):

CleanShot 2024-11-13 at 11 59 29@2x

What was the downside for you of Turbo that made you rip it out again in tus-node-server?

@kvz kvz merged commit 07ca1ed into main Nov 13, 2024
1 check passed
@kvz kvz deleted the turbo branch November 13, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants