Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for entrypoint on one ip address #6483

Merged
merged 6 commits into from
Jul 16, 2020

Conversation

SimonHeimberg
Copy link
Contributor

@SimonHeimberg SimonHeimberg commented Mar 13, 2020

What does this PR do?

Show how to bind an entrypoint to a single ip address. Similar as earlyer by #1194.

Motivation

There is not mentioned anywhere in the doc that an IP address can be set for an entry point. (Except in #1193)
Started a list showing how to do the address matching for different orchestrators. Instructions for other orchestrators would be handy (as requested in #5059.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

I linked to original sources for users can find more details themselves.

@ldez
Copy link
Contributor

ldez commented Mar 13, 2020

Hello,

It will be better to add a dedicated example instead of changing an existing one.

@SimonHeimberg
Copy link
Contributor Author

SimonHeimberg commented Mar 16, 2020

I can write a short section within some days. Found the syntax for ipv6 on https://golang.org/pkg/net/#Listen and https://golang.org/pkg/net/#Dial

But this is the ip address from within the container. I still have no idea what ip address to choose for which provider (docker container, docker swarm, ...)

@ldez
Copy link
Contributor

ldez commented Mar 16, 2020

Just add a simple example in the entry point page: https://docs.traefik.io/v2.1/routing/entrypoints/#configuration-examples

@SimonHeimberg
Copy link
Contributor Author

I rebased and did force push because it was on the wrong branch.

@SimonHeimberg
Copy link
Contributor Author

ready for another review

@SimonHeimberg SimonHeimberg requested a review from dtomcej March 30, 2020 13:59
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested, we moved the content as example and removed the provider specific part.
Thanks
LGTM

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

SimonHeimberg and others added 5 commits July 16, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants