Export correct types #56
Merged
+573
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous iteration, because it did not test the exported types in any way, had two misses, one serious and one less so: - the less serious miss was that the object types were incorrectly set up for the tests, and could be simplified as well - the more serious miss was that the exported type for `TrackedArray` was missing all of the `Array` methods, so downstream consumers could not use it as an array!
- make eslint a direct dependency - configure `@typescript-eslint` rules to work for the library as it is currently, with an eye to improving safety in the future - fix a bunch of actual things we can safely improve *now*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous iteration, because it did not test the exported types in any way, had two misses, one serious and one less so:
TrackedArraywas missing all of theArraymethods, so downstream consumers could not use it as an array!Resolves #41
Additionally, in support of those changes, update the lint config and fix lint issues:
@typescript-eslintrules to work for the library as it is currently, with an eye to improving safety in the future