Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: supports to add gRPC dial options (#2035) #2043

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 23, 2019

Signed-off-by: nolouch [email protected]

What problem does this PR solve?

cherry-pick #2035

What is changed and how it works?

add an option.

Check List

Tests

  • Unit test

@nolouch nolouch requested review from disksing and rleungx December 23, 2019 04:05
@nolouch nolouch modified the milestones: v3.0.8, v2.1.19, v3.1.0-beta Dec 23, 2019
@nolouch nolouch added needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. cherry-pick labels Dec 23, 2019
@nolouch
Copy link
Contributor Author

nolouch commented Dec 23, 2019

/run-cherry-picker

@nolouch
Copy link
Contributor Author

nolouch commented Dec 23, 2019

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #2043 into release-3.0 will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0    #2043      +/-   ##
===============================================
+ Coverage        69.31%   69.53%   +0.21%     
===============================================
  Files              170      170              
  Lines            16787    16796       +9     
===============================================
+ Hits             11636    11679      +43     
+ Misses            4172     4141      -31     
+ Partials           979      976       -3
Impacted Files Coverage Δ
client/client.go 74.53% <100%> (+1.76%) ⬆️
server/grpc_service.go 58.63% <0%> (-1.28%) ⬇️
server/leader.go 78.77% <0%> (-0.82%) ⬇️
server/namespace_cluster.go 85.71% <0%> (+3.89%) ⬆️
server/util.go 72.61% <0%> (+4.45%) ⬆️
server/schedulers/random_merge.go 67.5% <0%> (+5%) ⬆️
server/coordinator.go 85.55% <0%> (+6.29%) ⬆️
server/schedulers/shuffle_hot_region.go 65.38% <0%> (+6.41%) ⬆️
pkg/grpcutil/grpcutil.go 25.92% <0%> (+7.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fea0f0...43162f9. Read the comment docs.

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch
Copy link
Contributor Author

nolouch commented Dec 23, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 23, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 23, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 23, 2019

cherry pick to release-3.1 in PR #2046

sre-bot added a commit that referenced this pull request Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants