server: store cannot turn into tombstone due to limited resources #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previously this code would bury multiple stores, but now it will only bury one. |
|
@gregwebs You're absolutely right. I didn't notice that before. |
gregwebs
approved these changes
Aug 30, 2018
nolouch
reviewed
Aug 31, 2018
server/cluster.go
Outdated
| if c.storeIsEmpty(store.GetId()) { | ||
| err := c.BuryStore(store.GetId(), false) | ||
| offlineStore := store.Store | ||
| if c.storeIsEmpty(offlineStore.GetId()) { |
There was a problem hiding this comment.
storeIsEmpty need to dump all regions. Can we improve it?
server/cluster.go
Outdated
| if !store.IsLowSpace(cluster.GetLowSpaceRatio()) { | ||
| allStoresFull = false | ||
| } | ||
| upStoreCount++ |
There was a problem hiding this comment.
will count the Tombstone store as up store?
disksing
reviewed
Aug 31, 2018
server/cluster.go
Outdated
| } | ||
| } | ||
|
|
||
| if offlineStores == nil { |
There was a problem hiding this comment.
It is a good habit to use len(offlineStores) == 0 instead, compare slice to nil could lead to unexpected result in some cases.
disksing
approved these changes
Sep 3, 2018
|
/rebuild |
rleungx
force-pushed
the
cannot-tombstone
branch
from
9eeecba to
7398c8d
Compare
disksing
reviewed
Sep 5, 2018
server/cluster.go
Outdated
| err := c.BuryStore(store.GetId(), false) | ||
| offlineStore := store.Store | ||
| // If the store is empty, it can be buried. | ||
| if cluster.isPrepared() && cluster.getStoreRegionCount(offlineStore.GetId()) == 0 { |
There was a problem hiding this comment.
Do we really need to check isPrepared() here? I've noticed that after #1225 all regions will be put to RegionsInfo on startup (regardless of whether the leader is nil)
rleungx
force-pushed
the
cannot-tombstone
branch
from
dde37fd to
1d1fe34
Compare
nolouch
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR closes #1221.
What is changed and how it works?
When setting a store to
Offline, it won't turn intoTombstone, if there are no extra space or nodes to accommodate the extra replicas. This PR will show warning message to let user know about it.Check List
Tests