server: try to replace the down replicas instead of removing directly #1222
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| // Copyright 2018 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package cases | ||
|
|
||
| import ( | ||
| "github.com/pingcap/kvproto/pkg/metapb" | ||
| "github.com/pingcap/pd/pkg/faketikv/simutil" | ||
| "github.com/pingcap/pd/server/core" | ||
| ) | ||
|
|
||
| func newMakeupDownReplicas() *Conf { | ||
| var conf Conf | ||
| var id idAllocator | ||
|
|
||
| for i := 1; i <= 4; i++ { | ||
| conf.Stores = append(conf.Stores, &Store{ | ||
| ID: id.nextID(), | ||
| Status: metapb.StoreState_Up, | ||
| Capacity: 1 * TB, | ||
| Available: 900 * GB, | ||
| Version: "2.1.0", | ||
| }) | ||
| } | ||
|
|
||
| for i := 0; i < 400; i++ { | ||
| peers := []*metapb.Peer{ | ||
| {Id: id.nextID(), StoreId: uint64(i)%4 + 1}, | ||
| {Id: id.nextID(), StoreId: uint64(i+1)%4 + 1}, | ||
| {Id: id.nextID(), StoreId: uint64(i+2)%4 + 1}, | ||
| } | ||
| conf.Regions = append(conf.Regions, Region{ | ||
| ID: id.nextID(), | ||
| Peers: peers, | ||
| Leader: peers[0], | ||
| Size: 96 * MB, | ||
| Keys: 960000, | ||
| }) | ||
| } | ||
| conf.MaxID = id.maxID | ||
|
|
||
| numNodes := 4 | ||
| down := false | ||
| e := &DeleteNodesInner{} | ||
| e.Step = func(tick int64) uint64 { | ||
| if numNodes > 3 && tick%100 == 0 { | ||
| numNodes-- | ||
| return uint64(1) | ||
| } | ||
| if tick == 300 { | ||
| down = true | ||
| } | ||
| return 0 | ||
| } | ||
| conf.Events = []EventInner{e} | ||
|
|
||
| conf.Checker = func(regions *core.RegionsInfo) bool { | ||
| sum := 0 | ||
| regionCounts := make([]int, 0, 3) | ||
| for i := 1; i <= 4; i++ { | ||
| regionCount := regions.GetStoreRegionCount(uint64(i)) | ||
| if i != 1 { | ||
| regionCounts = append(regionCounts, regionCount) | ||
| } | ||
| sum += regionCount | ||
| } | ||
| simutil.Logger.Infof("region counts: %v", regionCounts) | ||
|
|
||
| if down && sum < 1200 { | ||
| // only need to print once | ||
| down = false | ||
| simutil.Logger.Error("making up replicas don't start immediately") | ||
| return false | ||
| } | ||
|
|
||
| for _, regionCount := range regionCounts { | ||
| if regionCount != 400 { | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| } | ||
| return &conf | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we abstract a statistic to evaluate different strategies instead of just print a log message? For example, we may count the number of regions with insufficient replicas in the scheduling process.