sbomnix: Use nixpkgs from sbomnix upstream #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henri Rosten <[email protected]>
henrirosten
force-pushed
the
fix-vulnix-runtime-scan
branch
from
025d7b9 to
68914bb
Compare
joinemm
approved these changes
Feb 11, 2025
|
Deployed to prod jenkins-controller VM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue with vulnix scans, an example error is here: https://ghaf-jenkins-controller-prod.northeurope.cloudapp.azure.com/job/ghaf-nightly-pipeline/62/execution/node/385/log/.
That same issue was fixed in vulnix upstream: nix-community/vulnix#101. The vulnix fix in nixpkgs has not been backported to 24.11, which is the nixpkgs version ghaf-infra flake currently follows. Therefore, if we enforce sbomnix to follow the 24.11 nixpkgs, it will use vulnix version
vulnix-1.10.1-unstable-2024-04-02which does not include the fix.To include the fix in ghaf-infra, we need to let sbomnix use a version of nixpkgs from nixos-unstable that includes vulnix version 1.10.2 with the fix included.