This repository has been archived by the owner on Oct 18, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I eagerly prepared this and only afterwards found #90, #119, docker-library/official-images#3383 and docker-library/official-images#3334.
Anyway, this was supposed to propose using the experimental
--squash
flag introduced in Docker 1.13.0 (see the release notes or moby/moby#22641) when building images. I realize there might be a better solution eventually but perfect is the enemy of good and changing it now doesn't prevent changing it again later.Rebuilding images from commit 727813e), this is the impact on size:
--squash
--squash
This shouldn't matter to most registries as they'll hopefully deduplicate content. The desired effect for me is reducing the five layers to a single layer which has a lot of impact when interacting with a registry as each layer causes a series of HTTP requests.
I realize this will properly be closed and that's fine although I would be happy to see it merged even if support is partial.