Team fixes+migration #1088
Merged
Team fixes+migration #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roffenlund
reviewed
Jan 20, 2025
django/thunderstore/repository/migrations/0055_delete_namespaces_without_team.py
Outdated
Show resolved
Hide resolved
Roffenlund
reviewed
Jan 20, 2025
django/thunderstore/repository/migrations/0055_delete_namespaces_without_team.py
Show resolved
Hide resolved
|
I think it’s a good idea to add a test for the migration. Also, please rebase on master to resolve the pre-commit build issue. |
Roffenlund
reviewed
Jan 20, 2025
Fix creating teams with taken namespaces by adding validation to save()
Fix leave team button logic, which previously only let you leave when there were two or more owners on a team
Migration to delete namespaces without a team
Remove unnecessary .lower() from team.py
x753
force-pushed
the
team-fixes+migration
branch
from
fc73984 to
d8523d7
Compare
Roffenlund
approved these changes
Jan 21, 2025
Closed
| def forwards(apps, schema_editor): | ||
| Namespace = apps.get_model("repository", "Namespace") | ||
|
|
||
| Namespace.objects.filter(team__isnull=True).delete() |
There was a problem hiding this comment.
This will break if the namespace has packages associated to it, so you should filter out namespaces with packages as well. I don't think the production db has any such instances but it is technically a bug so mentioning anyway.
| def forwards(apps, schema_editor): | ||
| Namespace = apps.get_model("repository", "Namespace") | ||
|
|
||
| Namespace.objects.filter(team__isnull=True).delete() |
There was a problem hiding this comment.
Suggested change
| Namespace.objects.filter(team__isnull=True).delete() | |
| Namespace.objects.filter(team__isnull=True, packages=None).delete() |
Deleting namespaces with packages won't work due to database constraints, so filter them out from the datamigration
MythicManiac
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to be merged after #1078
Cleans up the broken namespaces remaining in the database