Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend elf_aux_info() support for RISC-V on FreeBSD and OpenBSD #4376

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented Dec 26, 2024

No description provided.

@stweil
Copy link
Member

stweil commented Dec 26, 2024

Could you please explain in which scenario these changes are needed? The old code worked for me on RISC-V.

@amitdo
Copy link
Collaborator

amitdo commented Jan 13, 2025

@brad0,

Please reply to @stweil question.

@brad0 brad0 changed the title Fixes for elf_aux_info support Extend elf_aux_info() support for RISC-V Jan 16, 2025
@amitdo
Copy link
Collaborator

amitdo commented Jan 16, 2025

@stweil,

I found the answer to your question:

https://reviews.llvm.org/D109330

FreeBSD provides 'elf_aux_info' function that does the same as 'getauxval' on Linux.

@stweil
Copy link
Member

stweil commented Jan 16, 2025

@brad0, are you running FreeBSD (or another BSD variant) with RISC-V?

@amitdo
Copy link
Collaborator

amitdo commented Jan 16, 2025

@amitdo
Copy link
Collaborator

amitdo commented Jan 16, 2025

@stweil,

We're already doing the same thing for arm+neon:

https://github.com/search?q=repo%3Atesseract-ocr%2Ftesseract+elf_aux_info&type=code

@stweil stweil changed the title Extend elf_aux_info() support for RISC-V Extend elf_aux_info() support for RISC-V on FreeBSD and OpenBSD Jan 16, 2025
@stweil
Copy link
Member

stweil commented Jan 16, 2025

Right, similar code was added in pull request #3782.

@stweil stweil merged commit a5fa1bd into tesseract-ocr:main Jan 16, 2025
5 checks passed
@brad0
Copy link
Contributor Author

brad0 commented Jan 17, 2025

@brad0, are you running FreeBSD (or another BSD variant) with RISC-V?

Sorry, I was busy. Yes, OpenBSD, but it applies to FreeBSD too.

@brad0 brad0 deleted the bsd_elf_aux_info branch January 17, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants