Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support passing service project number to shared_vpc_access to be tf 0.13 compatible #500

Merged
merged 8 commits into from
Nov 24, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix name
  • Loading branch information
umairidris committed Nov 18, 2020
commit 0c65ba3175459ab80d4f75288f51ee3f775fc50d
14 changes: 7 additions & 7 deletions modules/shared_vpc/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,13 @@ module "project-factory" {
Setting API service accounts for shared VPC
*****************************************/
module "shared_vpc_access" {
source = "../shared_vpc_access"
host_project_id = var.shared_vpc
service_project_id = module.project-factory.project_id
active_apis = module.project-factory.enabled_apis
shared_vpc_subnets = var.shared_vpc_subnets
service_project_number = module.project-factory.project_number
lookup_service_project_number = false
source = "../shared_vpc_access"
host_project_id = var.shared_vpc
service_project_id = module.project-factory.project_id
active_apis = module.project-factory.enabled_apis
shared_vpc_subnets = var.shared_vpc_subnets
service_project_number = module.project-factory.project_number
lookup_project_number = false
}

/******************************************
Expand Down