[DRAFT] chore: parallel builds for int tests #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bharathkkb Please ping me once tests are passing / you're ready for review. |
|
/gcbrun |
|
@morgante looks like this has stabilized and we have some savings in build time too. ~45m -> ~15m. |
morgante
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently CI for PF seems to be failing at the destroy step. For instance #450
I have been unable to repro locally but my theory is that it is due to multiple gcloud destroys happening in the same build step. This aims to build them in separate build steps in parallel.
edit: that alone did not solve the problem completely, ended up skipping gcloud for all but one example
Changelist
GCLOUD_TF_DOWNLOAD=alwaysGCLOUD_TF_DOWNLOAD=neverfor minimal example