chore(master): release 4.0.0

[release-please]

🤖 I have created a release beep boop

4.0.0 (2023-04-06)

⚠ BREAKING CHANGES

• add support for custom_placement_config (#231)
• TPG >= 4.42: add support for public_access_prevention (#218)
• location inverse control in bucket name prefix (#186)
• Add matches_prefix and matches_suffix conditions (#202)

Features

• Add matches_prefix and matches_suffix conditions (#202) (8db2eb3)
• add support for custom_placement_config (#231) (a0bbdbd)
• Hmac access (#181) (e5e4909)
• location inverse control in bucket name prefix (#186) (dbd3c35)
• TPG >= 4.42: add support for public_access_prevention (#218) (4469954)

---

This PR was generated with Release Please. See documentation.

[comment-bot-dev]

@release-please[bot]
Thanks for the PR! 🚀
✅ Lint checks have passed.

[lhriley]

I ran into some state issues related to the provider upgrade. To fix it I had to edit state manually, so I came up with a little bashism to do it for me (requires ~jq-1.6):

Terraform

terraform state pull | sed "s/bucket_policy_only/uniform_bucket_level_access/g" | jq -M '.serial = (.serial + 1)' | jq -M 'del (.resources[].instances[].attributes["b64"])' | terraform state push -

Terragrunt:

terragrunt state pull | sed "s/bucket_policy_only/uniform_bucket_level_access/g" | jq -M '.serial = (.serial + 1)' | jq -M 'del (.resources[].instances[].attributes["b64"])' | terragrunt state push -

You might add this to the changelog or README.md to help people avoid issues upgrading.

[dpebot]

/gcbrun

[nhuray]

@lhriley What's missing to release that version ?

I would like to use it in order to not have the GCP region into the bucket name !

[lhriley]

@lhriley What's missing to release that version ?

I would like to use it in order to not have the GCP region into the bucket name !

The problem I had was a jump in a major version of Google and hashicorp providers that causes a breaking state change. This happened because of the change to the minimum version of the Google provider. The commands I shared fixed the state for me and now I'm running the pre-release without any apparent issues.

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[mirobertod]

Hi guys, any ETA for this release?
Thanks!

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[furlangiacomo]

Hello, any update on when this PR will be merged? Thanks!

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[apeabody]

We should probably try to include #185 in this breaking release.

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[CharlieC3]

Would love to see this merged soon, is there something currently blocking it? If #185 is the blocker, I don't see much activity going on there either. For the sake of time, maybe #185 can be included in a later release?

[apeabody]

Would love to see this merged soon, is there something currently blocking it? If #185 is the blocker, I don't see much activity going on there either. For the sake of time, maybe #185 can be included in a later release?

Hi @CharlieC3 - We could push #185 to a later release, however it appears the upgrade guide https://github.com/terraform-google-modules/terraform-google-cloud-storage/blob/master/docs/upgrading_to_v4.0.md may need an addition to cover state migration: #214 (comment)

@imrannayer - Would you happen to be familiar?

[imrannayer]

@apeabody I created bucket using current module version 3.4.1 and then ran terraform apply using code for module version 4.0. I am not able to reproduce the problem mentioned in #214 (comment).
We have been using uniform_bucket_level_access in our module since release 1.7

[apeabody]

@apeabody I created bucket using current module version 3.4.1 and then ran terraform apply using code for module version 4.0. I am not able to reproduce the problem mentioned in #214 (comment). We have been using uniform_bucket_level_access in our module since release 1.7

Thanks @imrannayer! Possibly related to prior major version upgrades.

[dpebot]

/gcbrun

[release-please]

🤖 Release is at https://github.com/terraform-google-modules/terraform-google-cloud-storage/releases/tag/v4.0.0 🌻