feat: Add variable to allow disabling the package timestamp trigger #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpetrucciani
changed the title
|
I will rebase and fix this - this simplifies my change as well, since the latest commit bumps the lambda version to nearly the same thing I had! |
jpetrucciani
force-pushed
the
disable_trigger_on_package_timestamp
branch
from
ec94dba to
0765d88
Compare
|
Should be good for review now! |
antonbabenko
approved these changes
Sep 3, 2024
antonbabenko
pushed a commit
that referenced
this pull request
Sep 3, 2024
## [6.5.0](v6.4.1...v6.5.0) (2024-09-03) ### Features * Add variable to allow disabling the package timestamp trigger ([#233](#233)) ([b3016e2](b3016e2))
|
This PR is included in version 6.5.0 🎉 |
|
Thank you! |
gdacunda
pushed a commit
to zype/terraform-aws-notify-slack
that referenced
this pull request
Oct 3, 2024
…raform-aws-notify-slack into INF-2667 * 'master' of https://github.com/terraform-aws-modules/terraform-aws-notify-slack: chore(release): version 6.5.0 [skip ci] feat: Add variable to allow disabling the package timestamp trigger (terraform-aws-modules#233) chore(release): version 6.4.1 [skip ci] fix: Update `aws_sns_topic_subscription` endpoint to use qualified arn (terraform-aws-modules#231) chore(release): version 6.4.0 [skip ci] feat: Improved AWS backup notification readability (terraform-aws-modules#222) chore(release): version 6.3.0 [skip ci] feat: Update Python lambda runtime from `3.8` to `3.11` (terraform-aws-modules#225) chore(release): version 6.2.0 [skip ci] feat: Added architecture variable (terraform-aws-modules#224) chore(release): version 6.1.2 [skip ci] fix: Correct assume role permissions for SNS service to assume IAM role (terraform-aws-modules#220) chore(release): version 6.1.1 [skip ci] fix: Update CI workflow versions to remove deprecated runtime warnings (terraform-aws-modules#218)
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a variable (default false) for triggering an update of the underlying lambda based on the timestamp of the underlying file
Motivation and Context
This fixes the case where this module is used and automatically planned/applied from CI, where the source is freshly copied/cloned - currently, the module will always attempt to update the lambda in this case!
Fixes #232
Breaking Changes
This does bump the underlyingterraform-aws-modules/terraform-aws-lambdaversion from3.2.0->6.7.0(the minimum that supports this option) - but the only breaking changes I can see from that are that onlyterraform >= 1is supported, and it requires a slightly newer AWS providerThis originally bumped the version of the lambda module from
3.2.0->6.7.0- but master has changed to6.8.0!How Has This Been Tested?
I have used this in my fork of the repo to deploy a few times within my CI pipelines
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request