fix: Replace IteratorStep with NextMethod #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #33. Prevents an infinite loop caused by IteratorStep(iteratorRecord) not actually flagging termination when IteratorRecord is async. Instead, we will directly call iteratorStep.[[NextMethod]], like how `for await` does. Co-Authored-By: Kevin Gibbons <[email protected]>
trflynn89
reviewed
Dec 24, 2023
| 1. Set _nextResult_ to ? Await(_nextResult_). | ||
| 1. If _nextResult_ is not an Object, throw a *TypeError* exception. | ||
| 1. Let _done_ be ? IteratorComplete(_nextResult_). | ||
| 1. If _done_ is *true*, | ||
| 1. Perform ? Set(_A_, *"length"*, 𝔽(_k_), *true*). | ||
| 1. Return Completion Record { [[Type]]: ~return~, [[Value]]: _A_, [[Target]]: ~empty~ }. | ||
| 1. Let _nextValue_ be ? IteratorValue(_next_). |
There was a problem hiding this comment.
Hey! Sorry for the post-merge review comment, but should this now be IteratorValue(_nextResult_)?
There was a problem hiding this comment.
You’re right. Thank you for spotting this. I opened #45 and plan to merge it in a few days if nobody else spots any more problems.
js-choi
added a commit
that referenced
this pull request
Dec 24, 2023
Finish #44’s change, which fixes #33. Co-Authored-By: Kevin Gibbons <[email protected]> #44 renamed _next_ to _nextResult_ but one reference was left unchanged. Spotted by @trflynn89.
js-choi
added a commit
that referenced
this pull request
Dec 24, 2023
Finish #44’s change, which fixes #33. Co-Authored-By: Kevin Gibbons <[email protected]> #44 renamed _next_ to _nextResult_ but one reference was left unchanged. Spotted by @trflynn89.
js-choi
added a commit
that referenced
this pull request
Dec 27, 2023
Finish #44’s change, which fixes #33. Co-Authored-By: Kevin Gibbons <[email protected]> #44 renamed _next_ to _nextResult_ but one reference was left unchanged. Spotted by @trflynn89.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33.
Prevents an infinite loop caused by IteratorStep(iteratorRecord) not actually flagging termination when IteratorRecord is async. Instead, we will directly call iteratorStep.[[NextMethod]], like how
for awaitdoes. Uses the patch suggested by @bakkot.