Skip to content

Fix badCallback will only throw if iterable has items #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2021
Merged

Fix badCallback will only throw if iterable has items #15

merged 1 commit into from
Dec 16, 2021

Conversation

senocular
Copy link
Contributor

This is consistent with Array.from where Array.from([], ()=>{throw 1}) will not throw but Array.from([1], ()=>{throw 1}) will.

@senocular
Fix badCallback will only throw if iterable has items
e9a5e09 
This is consistent with Array.from where `Array.from([], ()=>{throw 1})` will not throw but `Array.from([1], ()=>{throw 1})` will.
@js-choi js-choi added bug Something isn't working documentation Improvements or additions to documentation labels Dec 16, 2021
@js-choi js-choi merged commit 7ca3452 into tc39:main Dec 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@senocular @js-choi