Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d8: Remove experimental notice from stderr #139

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

ptomato
Copy link
Contributor

@ptomato ptomato commented Oct 24, 2023

If you invoke d8 with any --harmony flags, it prints a warning to stderr that you are using experimental technologies. Remove this warning from the captured stderr, because it's just noise - if you are running d8 with a --harmony flag via eshost, you probably know what you are doing.

Additionally, non-empty stderr makes test262harness think the test has failed, so it's currently impossible to run test262 tests for a --harmony feature.

If you invoke d8 with any --harmony flags, it prints a warning to stderr
that you are using experimental technologies. Remove this warning from
the captured stderr, because it's just noise - if you are running d8
with a --harmony flag via eshost, you probably know what you are doing.

Additionally, non-empty stderr makes test262harness think the test has
failed, so it's currently impossible to run test262 tests for a
--harmony feature.
Copy link
Contributor

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually still an issue at all?

$ ~/.esvu/bin/v8 </dev/null
V8 version 13.7.67
d8> 
$ ~/.esvu/bin/v8 --harmony -e 'print("loaded")'
loaded

@ptomato
Copy link
Contributor Author

ptomato commented Apr 8, 2025

Apparently is still an issue if you use a more specific --harmony flag:

~/.esvu/bin/v8 --harmony-temporal
V8 is running with experimental features enabled. Stability and security will suffer.
V8 version 13.7.67
d8>

Co-authored-by: Richard Gibson <[email protected]>
@ptomato ptomato requested a review from gibson042 April 8, 2025 21:18
@gibson042 gibson042 merged commit 1614fb1 into tc39:master Apr 8, 2025
@ptomato ptomato deleted the d8-experimental-notice branch April 8, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants